Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented Generic AsyncIterator #78

Closed
wants to merge 7 commits into from
Closed

Implemented Generic AsyncIterator #78

wants to merge 7 commits into from

Commits on Feb 14, 2019

  1. Added generic AsyncIterator implementation so other PubSubEngine impl… 

    …ementations won't have to implement their own AsyncIterator.
    @jedwards1211
    Alex Leung authored and jedwards1211 committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    41bb8a8 View commit details
    Browse the repository at this point in the history

  2. used T correctly

    @jedwards1211
    Alex Leung authored and jedwards1211 committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    a43e386 View commit details
    Browse the repository at this point in the history

  3. fixed pubsub-async-iterator documentation typos

    @ozyman42 @jedwards1211
    ozyman42 authored and jedwards1211 committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    fce6367 View commit details
    Browse the repository at this point in the history

  4. Updated 'PubSub Implementation` section of README to mention that Pub… 

    …SubEngine is now an abstract class with an opt-in default AsyncIterator implementation. Also removed a couple of trailing white spaces.
    @ozyman42 @jedwards1211
    ozyman42 authored and jedwards1211 committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    bd4e469 View commit details
    Browse the repository at this point in the history

  5. updated CHANGELOG.md

    @ozyman42 @jedwards1211
    ozyman42 authored and jedwards1211 committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    6e6f680 View commit details
    Browse the repository at this point in the history

  6. fixed PR link in CHANGELOG.md

    @ozyman42 @jedwards1211
    ozyman42 authored and jedwards1211 committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    9dc056d View commit details
    Browse the repository at this point in the history

  7. fix(PubSubAsyncIterator): don't subscribe until first call to next()

    @jedwards1211
    jedwards1211 committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    a90f587 View commit details
    Browse the repository at this point in the history