Implement ES6 export file #325
Conversation
|
This PR is mostly a rebase of #273 |
|
What's the hangup on getting this merged? |
|
@PowerKiKi Thanks for the ping! I recently got my GitHub notifications under control(-ish), so hopefully I won't miss stuff like this in the future. @hwillson Any thoughts/recollections as to why we hadn't done this before? Was it just that we wanted to convert the package to TypeScript first? |
Exactly! |
|
Another ESM-incompatible npm package used by |
This upgrade all dev dependencies in order to implement ES6 exports in order to solve apollographql#303. This also remove yarn.lock entirely because this package is meant to work with npm only as can be seen from the mention of npm command in package.json. Fixes apollographql#303 Closes apollographql#272 Closes apollographql#273
The loader.js module is still CommonJS, since that's what webpack wants,
and importing the package with require("graphql-tag") still returns the
gql function, rather than an exports object, for backwards compatibility.
I converted the tests to TypeScript, since the type checking is useful for
test code. Mocha now runs a CommonJS test bundle generated by Rollup.
There was a problem hiding this comment.
Thanks for getting this started @PowerKiKi, and please let us know if you have any concerns about the additional commits that I pushed.
|
Thank you for merging this. I would like to emphasize that all credits should go to @abdonrd 🎉 . I merely rebased his work. |
|
Thanks for the mention @PowerKiKi! |
This upgrade all dev dependencies in order to implement ES6 exports
in order to solve #303.
This also remove yarn.lock entirely because this package is meant to
work with npm only as can be seen from the mention of npm command in
package.json.
Fixes #303
Closes #272
Closes #273