Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw as Error to prevent certain issues #446

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

boboldehampsink
Copy link
Contributor

Fixes this warning: Syntax Error: NonErrorEmittedError: (Emitted value instead of an instance of Error) Query/mutation names are required for a document with multiple definitions

Fixes this warning: `Syntax Error: NonErrorEmittedError: (Emitted value instead of an instance of Error) Query/mutation names are required for a document with multiple definitions`
@apollo-cla
Copy link

@boboldehampsink: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Copy link
Member

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, though of course JavaScript itself allows throwing any value. Thanks @boboldehampsink.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants