Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiled current version and removed maximum call stack exception #45

Closed
wants to merge 1 commit into from

Conversation

KordonDev
Copy link

My changes are in index.js. #40

The changes of the other files occur because I run npm run compile.

@apollo-cla
Copy link

@KordonDev: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@abhiaiyer91
Copy link
Contributor

@KordonDev is there a reason why we need startToken, endToken if we're trying to strip all loc fields in the AST?

@abhiaiyer91
Copy link
Contributor

We have a goal of not bundling graphql printer and parser ourselves found here
#46

so lets see if we actually need the references to the tokens. if we do, then we can modify the PR here and ship the removal of our webpack bundle as well.

@KordonDev
Copy link
Author

I'm not understanding the whole library. My goal was to remove the error and the merge request is for other people with the same issue.

So if you remove the tokens, feel free to close my merge request.

@jnwng
Copy link
Contributor

jnwng commented Feb 7, 2017

@KordonDev thanks for the PR! as you mentioned, i think #46 should resolve the issue (it also removes the tokens) and takes care of removing some of the generated GraphQL modules as well - closing this PR to reflect that.

@jnwng jnwng closed this Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants