[Feature] Support lexical parser options

[coleturner]

This adds the ability to specify parseOptions through makeExecutableSchema into graphql.parse - unlocking finer control of lexical options when building a schema.

Motivation

I'm working with tooling where I would like to be able to parse an empty schema Query type. As of today, it's not possible with graphql-tools because types must have at least one field. This is possible with graphql currently in master, albeit as of now those options are legacy or experimental feature flags. There are other use cases, such as noLocation which can be used to optimize AST building. It's nice to have these options as they are now and possibly what may be added in the future.

Creating this pull request for consideration once the master branch and all current options are deployed to NPM.

What's changed

• Added parseOptions to makeExecutableSchema parameters
• Carried parseOptions from makeExecutableSchema to graphql/parse
• Added tests for current lexical parser options.

Current options supported:

• noLocation
• allowLegacySDLEmptyFields (pending publish)
• allowLegacySDLImplementsInterfaces (pending publish)
• experimentalFragmentVariables (pending publish)

Example

makeExecutableSchema({
  typeDefs: `
    type RootQuery {
    }
    schema {
      query: RootQuery
    }
  `,
  resolvers: {
  },
  parseOptions: {
    allowLegacySDLEmptyFields: true
  },
});

Related

graphql/graphql-js#1171
graphql/graphql-js@c496fb7
graphql/graphql-js@ce0a4b9

Tasks

• If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
• Make sure all of the significant new logic is covered by tests
• Rebase your changes on master so that they can be merged easily
• Make sure all tests and linter rules pass
• Update CHANGELOG.md with your change

[freiksenet]

Sorry for update spam, github was misbehaving with conflict resolution. This fails because graphql-js haven't released version with those changes yet. I'll merge it once it's released.

[coleturner]

Thanks for reviewing, I'll keep an eye out for the next release of graphql. Cheers!

[stubailo]

Has the upstream stuff been published yet?

[coleturner]

Not yet, it's been over a month since last release of graphql-js

[coleturner]

Release should be coming soon:
https://github.com/graphql/graphql-js/releases/tag/v0.13.0-rc.1

[coleturner]

GraphQL-JS @ 0.13.0 has released

I rebased my PR from master, updated the package versions, and ran tests again (passing locally ✅)

[freiksenet]

@colepatrickturner I get typescript errors locally atm:

src/schemaGenerator.ts(241,7): error TS2365: Operator '===' cannot be applied to types '"OperationDefinition" | "FragmentDefinition" | "SchemaDefinition" | "ScalarTypeDefinition" | "Obj...' and '"TypeExtensionDefinition"'.

[freiksenet]

Other stuff this PR needs:

• Get new TS definitions that include parseOptions and update them in devDependencies
• Update graphql version in peerDependencies and devDependencies
• Add 0.13 to travis feature matrix
• Disable new tests for 0.11 and 0.12 using feature matrix env var
• Update tests in mergeSchema to use new inheritance syntax, put 0.12 definitions under flag.

[freiksenet]

(Though we could possibly split the above into "support 0.13" PR)

[coleturner]

Woops I forgot to push it yesterday. Will go through the checklist

[coleturner]

• Get new TS definitions that include parseOptions and update them in devDependencies feat(GraphQL): add additional GraphQL ParseOptions DefinitelyTyped/DefinitelyTyped#23525
• Update graphql version in peerDependencies and devDependencies 8e05c2a
• Add 0.13 to travis feature matrix 5a93b66
• Disable new tests for 0.11 and 0.12 using feature matrix env var
• Update tests in mergeSchema to use new inheritance syntax, put 0.12 definitions under flag.

With the versioning matrix, I wrote it such that npm run test will run all tests if no matrix version is set. When set the various options are only available if they are >= the matrix version.

[freiksenet]

@colepatrickturner Thank you so much for handling this! Waiting for the TS to merge and I'll release.

[freiksenet]

@colepatrickturner Could you enable me to push to your branch? I have fixes that make tests pass.

[coleturner]

@freiksenet I have added you as a contributor to my fork

[freiksenet]

Urgh, there is issue with graphql-subscriptions not supporting 0.13 yet, so non-v5 npm fails. Waiting for this to land. apollographql/graphql-subscriptions#135

[freiksenet]

(╯°□°）╯︵ ┻━┻

Now it works.