Annotate sanitized InvariantErrors with numeric error codes. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inspired by apollographql/apollo-client#4519. Given the { errorCodes: true } option, rollup-plugin-invariant will now transform invariant(condition, message) into process.env.NODE_ENV === 'production' ? invariant(condition, <number>) : invariant(condition, message) and new InvariantError(message) into process.env.NODE_ENV === 'production' ? new InvariantError(<number>) : new InvariantError(message) so that production errors can be traced back to the place in the unminified source code where they were thrown. Since the full development version of the error is always colocated with the production one, it should be relatively easy to determine the nature of the error. The message for these sanitized errors will look like this: Invariant Violation: <number> (see https://github.com/apollographql/invariant-packages) The provided URL is appended by the InvariantError constructor within the ts-invariant package, so it will not be repeated at every call site.
hwillson
approved these changes
Mar 2, 2019
benjamn
added a commit
to apollographql/apollo-client
that referenced
this pull request
Mar 2, 2019
Inspired by #4519. Implemented and explained by apollographql/invariant-packages#1.
benjamn
added a commit
to apollographql/apollo-client
that referenced
this pull request
Mar 4, 2019
Inspired by #4519. Implemented and explained by apollographql/invariant-packages#1.
benjamn
added a commit
to apollographql/apollo-client
that referenced
this pull request
Mar 4, 2019
Inspired by #4519. Implemented and explained by apollographql/invariant-packages#1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by apollographql/apollo-client#4519.
Given the
{ errorCodes: true }option, rollup-plugin-invariant will now transforminto
and
into
so that production errors can be traced back to the place in the unminified source code where they were thrown. Since the full development version of the error is always colocated with the production one, it should be relatively easy to determine the nature of the error.
The messages for these sanitized errors will look like this:
The provided URL is appended by the InvariantError constructor within the
ts-invariantpackage, so it will not be repeated at every call site.