This repository has been archived by the owner on Aug 20, 2020. It is now read-only.
Strict null checks #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stubailo Could you take a look at this when you have a bit of time? I can't review at the moment 👎 |
|
I would greatly appreciate this being merged in, the error case is stopping me from being able to use this in my project. |
There was a problem hiding this comment.
I just did PR #63 which is a one liner then realised I should have checked for other PR's.
This PR #31 has lot's of changed but also a 4-liner in src/network_interface/ApolloNetworkInterface.ts which is a better solution for the integrated / not standalone version.
Is it ok to take those lines into #63?
Next we can close this diverged patch with lots of unrelated (with respect to the issues title that is 😄) changes.
clemens-tolboom
added a commit
to clemens-tolboom/persistgraphql
that referenced
this pull request
May 27, 2018
Credits to @Aides359 from apollographql#31
|
I added the mentioned lines into PR #63. Hope that was OK 😃 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle the case when no query document is passed (assuming an error should be thrown).
Also enabled
strictNullChecksto ensure comptibility with this compiler flag.Feel free to provide feeback if this is not the wanted behaviour.