Update error template to fix Codesandbox issues #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
alessbell
reviewed
Jul 29, 2022
| @@ -3,9 +3,10 @@ | |||
| "name": "apollo-client-error-template", | |||
| "version": "1.0.0", | |||
| "license": "MIT", | |||
| "main": "src/index.jsx", | |||
There was a problem hiding this comment.
Does this need to be set for codesandbox?
There was a problem hiding this comment.
Yep! That or renaming index.jsx to index.js, which feels wrong because it has jsx elements
hwillson
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per these issues: apollographql/apollo-client#9846 and apollographql/apollo-client#9659, it looks like
graphqlversion16doesn't work on Codesandbox. This PR updates the package.json and dependabot config to keep it on version 15.6.1 until this is resolved.Furthermore, this manually sets
index.jsxas the default entrypoint, as it looks likecreate-react-appno longer automatically looks at.jsxfiles for entrypoints.Codesandbox for this PR: https://codesandbox.io/s/react-apollo-error-template-mdbfix-vtfnw4
PS: Also this splits the Link and Schema definition into their own files, as having everything in one long chunk seemed against the sensibilities of both ESLint and myself. LMK if I should revert this change.