This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
Do not update query after changing ApiClient #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@valerybugakov: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
|
@valerybugakov wonderful! Could you update the changelog and add a test for this? |
valerybugakov
added a commit
to valerybugakov/react-apollo
that referenced
this pull request
Sep 27, 2017
valerybugakov
force-pushed
the
master
branch
from
0c1db2c to
21f3ba2
Compare
|
@jbaxleyiii added test case and rebased with master |
jbaxleyiii
approved these changes
Oct 15, 2017
|
We're bitten by this. Any chance we can land it in master and release it? |
|
ping again, @jbaxleyiii @valerybugakov. It was NOT merged to master, and could anyone confirm? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using another ApiClient with graphql container and mutation causes running of
this.updateQuery(nextProps);which should not be executed for mutation from my understanding.Fixes already closed #812.