Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

[WIP] Add @defer support #2192

Closed
wants to merge 6 commits into from
Closed

[WIP] Add @defer support #2192

wants to merge 6 commits into from

Conversation

clarencenpy
Copy link

@clarencenpy clarencenpy commented Jul 17, 2018

Changes:

  • Expose loadingState on the Query component for deferred queries.
  • When a deferred query component is unmounted, do not tear down the subscription so deferred fields can continue to stream in.

@clarencenpy
Copy link
Author

This build is failing as it depends on changes in apollo-client #3686. Can we release an alpha version of AC, and pin the dependency here?

Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @clarencenpy! Yes, we can definitely get an alpha of AC out. It looks like we'll need an Apollo Link alpha out first though, so we'll revisit this after the related @defer Apollo Link and Apollo Client PR's are ready to go. Thanks!

@joeflack4
Copy link

+1

@hwillson hwillson changed the title Add @defer support [WIP] Add @defer support Sep 28, 2018
@hwillson
Copy link
Member

hwillson commented Mar 6, 2019

We're going to close this PR for now, and re-open it when we're ready to dive back into the @defer work (when the necessary Apollo Server request pipeline changes have been made, to better support @defer functionality).

@hwillson hwillson closed this Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants