This repository was archived by the owner on Apr 13, 2023. It is now read-only.
MockNetworkInterface match mock requests regardless of variable order #973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@L1fescape: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
|
@L1fescape, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jbaxleyiii, @calebmer and @mmissey to be potential reviewers. |
Contributor
|
@L1fescape thank you! This looks great to me! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently mock data needs to exactly match the request being made within a component being tested. This is because requests object are stringified and used as keys when registering and looking up the corresponding response objects to be returned. This change sorts the request object when it is stringified so the order of variables doesn't matter.
This issue is discussed in #674