This repository has been archived by the owner on May 26, 2023. It is now read-only.
Bs platform 7 #222
Merged
Bs platform 7 #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gregoirevda
commented
Dec 23, 2019
| _ = | ||
| ""; | ||
|
|
||
| // [@bs.obj] |
There was a problem hiding this comment.
Probably delete
There was a problem hiding this comment.
Yes, as not used anymore in createApolloClient
Gregoirevda
commented
Dec 23, 2019
| ), | ||
| ); | ||
| }; | ||
| // let webSocketLink = (~uri, ~reconnect=?, ~connectionParams=?, ()) => { |
There was a problem hiding this comment.
Can be deleted as all links should be in ApolloLinks
Gregoirevda
commented
Dec 23, 2019
| type webSocketLinkOptionsT = { | ||
| [@bs.optional] | ||
| reconnect: bool, |
There was a problem hiding this comment.
optional in the new typed object
Gregoirevda
commented
Dec 23, 2019
| ), | ||
| ) | ||
| jsMutation({variables, refetchQueries, optimisticResponse}) | ||
| // jsMutation( |
Gregoirevda
commented
Dec 23, 2019
| . | ||
| "subscriptionData": Js.Nullable.t(Js.Json.t), | ||
| "variables": Js.Nullable.t(Js.Json.t), | ||
| subscriptionData: option(Js.Json.t), |
There was a problem hiding this comment.
Can be null & undefined: switch to Js.Nullable.t
Gregoirevda
commented
Dec 23, 2019
| "subscriptionData": Js.Nullable.t(Js.Json.t), | ||
| "variables": Js.Nullable.t(Js.Json.t), | ||
| subscriptionData: option(Js.Json.t), | ||
| variables: option(Js.Json.t), |
There was a problem hiding this comment.
Can be null & undefined: switch to Js.Nullable.t
|
In general double check |
|
@idkjs Thanks a lot for your work!! I added some comments to myself, not sure if always relevant, but need to look into. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Labels
bs platform 7 support