Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from clap 3.1.18 to 3.2 #1231

Closed
o0Ignition0o opened this issue Jun 14, 2022 · 0 comments · Fixed by #1395
Closed

Migrate from clap 3.1.18 to 3.2 #1231

o0Ignition0o opened this issue Jun 14, 2022 · 0 comments · Fixed by #1395
Assignees
@Geal
Labels
bug

Comments

@o0Ignition0o
Copy link
Contributor

A minor release of clap happened yesterday, which changes the behavior or argument matching and leads plugin writers to hit an error when they run:

ignition@ignition-apollo test % cargo r -- --supergraph ./local.graphql 
    Finished dev [unoptimized + debuginfo] target(s) in 0.42s
     Running `target/debug/router --supergraph ./local.graphql`
thread 'main' panicked at 'Must use `_os` lookups with `Arg::allow_invalid_utf8` at `supergraph-path`', /Users/ignition/.cargo/git/checkouts/router-18de2f110854a520/dfbfea0/apollo-router/src/executable.rs:314:49
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

We are working around this by pinning the dependency to clap = "3.1.18" but we need to find the root cause and address it.
o0Ignition0o added a commit that referenced this issue Jun 14, 2022
@o0Ignition0o
Pin clap dependency in Cargo.toml
3f9f8a9 
Workaround against #1231

A minor release of Clap occured yesterday; which introduced a breaking change.

This might lead cargo scaffold users to hit a panic a runtime when the router tries to parse env variables and arguments.

This patch Pins the clap dependency to the version that was available before the release, until the root cause is found and fixed.
@o0Ignition0o o0Ignition0o mentioned this issue Jun 14, 2022
Merged
o0Ignition0o added a commit that referenced this issue Jun 14, 2022
@o0Ignition0o
Pin clap dependency in Cargo.toml (#1232)
736c00c 
Workaround against #1231

A minor release of Clap occured yesterday; which introduced a breaking change.

This might lead cargo scaffold users to hit a panic a runtime when the router tries to parse env variables and arguments.

This patch Pins the clap dependency to the version that was available before the release, until the root cause is found and fixed.
@Geal Geal mentioned this issue Jul 13, 2022
Merged
@Geal Geal self-assigned this Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Geal Geal

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update clap and add a special case for PathBuf arguments apollographql/router
2 participants
@Geal @o0Ignition0o