Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change the state machine log verbosity level to be trace #1578

Closed
abernix opened this issue Aug 23, 2022 · 2 comments · Fixed by #1597
Closed

change the state machine log verbosity level to be trace #1578

abernix opened this issue Aug 23, 2022 · 2 comments · Fixed by #1597
Assignees
@abernix

Comments

@abernix
Copy link
Member

abernix commented Aug 23, 2022

right now the state machine prints a lot of messages which are a bit too verbose (like the transitioned to started multiple times messages)

i think those can be made trace?
@abernix
Copy link
Member Author

abernix commented Aug 23, 2022 •
edited
Loading

Should it be trace or debug? (It is currently info, I think)

@o0Ignition0o
Copy link
Contributor

Debug sounds fair to me, enabling trace looking for them would be too noisy imo

abernix added a commit that referenced this issue Aug 24, 2022
@abernix
Change verbosity of state machine logs to trace
89f6ab5 
This changes the verbosity of messages like `transitioned to starting` from
the `info` level to the `trace` level since messages about the state machine
aren't necessary user-facing information during normal operation.

Closes #1578
@abernix abernix mentioned this issue Aug 24, 2022
Merged
abernix added a commit that referenced this issue Aug 24, 2022
@abernix
Add CHANGELOG.md for #1578
98fab40
Geal pushed a commit that referenced this issue Aug 26, 2022
@abernix
Change verbosity of state machine logs to trace (#1597)
554b033 
This changes the verbosity of messages like `transitioned to starting` from
the `info` level to the `trace` level since messages about the state machine
aren't necessary user-facing information during normal operation.

Closes #1578
@abernix abernix mentioned this issue Aug 29, 2022
Merged
@abernix abernix added this to the v1.0.0-alpha.0 milestone Aug 29, 2022
@abernix abernix self-assigned this Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abernix abernix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change verbosity of state machine logs to trace apollographql/router
2 participants
@abernix @o0Ignition0o