Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Status propagation plugin #1662

Closed
krisztian-sala opened this issue Aug 31, 2022 · 1 comment · Fixed by #1664
Closed

Status propagation plugin #1662

krisztian-sala opened this issue Aug 31, 2022 · 1 comment · Fixed by #1664
Assignees
@o0Ignition0o
Labels
raised by user

Comments

@krisztian-sala
Copy link

The example status code propagation plugin is not working as expected. Even though the subgraph returns a 401 status, the router still shows 200.
o0Ignition0o added a commit that referenced this issue Aug 31, 2022
@o0Ignition0o
Fix: Propagate graphql response regardless of the subgraph HTTP statu…
f037eb2 
…s code.

fixes: #1335, #1662

Subgraph service calls used to return an error when the received HTTP status code isn't 200.
There's however no mention in the GraphQL specification that leads us to assume anything about the HTTP status code returned by a GraphQL server.

This commit removes our HTTP status code check in the `subgraph_service`.
@o0Ignition0o o0Ignition0o self-assigned this Aug 31, 2022
@o0Ignition0o o0Ignition0o mentioned this issue Aug 31, 2022
Merged
o0Ignition0o added a commit that referenced this issue Aug 31, 2022
@o0Ignition0o
Fix: Propagate graphql response regardless of the subgraph HTTP statu…
cd1c7b4 
…s code.

fixes: #1335, #1662

Subgraph service calls used to return an error when the received HTTP status code isn't 200.
There's however no mention in the GraphQL specification that leads us to assume anything about the HTTP status code returned by a GraphQL server.

This commit removes our HTTP status code check in the `subgraph_service`.
@abernix abernix added this to the v1.0.0-alpha.1 milestone Aug 31, 2022
o0Ignition0o added a commit that referenced this issue Sep 1, 2022
@o0Ignition0o
Fix: Propagate graphql response regardless of the subgraph HTTP statu…
01014d7 
…s code. (#1664)

Fix: Propagate graphql response regardless of the subgraph HTTP status code.

fixes: #1335, #1662

Subgraph service calls used to return an error when the received HTTP status code isn't 200.
There's however no mention in the GraphQL specification that leads us to assume any intent behind the HTTP status code returned by a GraphQL server.

This commit removes our HTTP status code check in the `subgraph_service`.
@abernix
Copy link
Member

abernix commented Sep 2, 2022

Fixed by #1664

@abernix abernix closed this as completed Sep 2, 2022
@abernix abernix removed the triage label Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@o0Ignition0o o0Ignition0o

Labels
raised by user
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Propagate graphql response regardless of the subgraph HTTP status code. apollographql/router
3 participants
@abernix @o0Ignition0o @krisztian-sala