Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove file access in config #1772

Closed
BrynCooke opened this issue Sep 14, 2022 · 0 comments · Fixed by #1774
Closed

Remove file access in config #1772

BrynCooke opened this issue Sep 14, 2022 · 0 comments · Fixed by #1774
Assignees
@BrynCooke

Comments

@BrynCooke
Copy link
Contributor

Currently opentelemetry has configuration that allows injection of secrets from the file system or environment. This is problematic because:

  • There is already an environment injection mechanism in config.
  • By using file access a configuration can be used to access the contents of arbitrary files.

Proposal is that:

  • The secrets type is removed.
  • File access is retained through prefix file.. This can be configured via unsupported environment variable:
@BrynCooke BrynCooke self-assigned this Sep 14, 2022
@abernix abernix mentioned this issue Sep 14, 2022
Merged
BrynCooke added a commit that referenced this issue Sep 14, 2022
@BrynCooke @o0Ignition0o
Otel configuration updated to use expansion (#1774)
d13a9de 
Fixes #1772

File and env access in configuration now use the generic expansion
mechanism introduced in
[#1759](#1759).

```yaml
      grpc:
        key:
          file: "foo.txt"
        ca:
          file: "bar.txt"
        cert:
          file: "baz.txt"
```

Becomes:
```yaml
      grpc:
        key: "${file.foo.txt}"
        ca: "${file.bar.txt}"
        cert: "${file.baz.txt}"
```
or
```yaml
      grpc:
        key: "${env.FOO}"
        ca: "${env.BAR}"
        cert: "${env.BAZ}"
```

Co-authored-by: bryn <bryn@apollographql.com>
Co-authored-by: Jeremy Lempereur <jeremy.lempereur@gmail.com>
@abernix abernix mentioned this issue Sep 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrynCooke BrynCooke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Otel configuration updated to use expansion apollographql/router
1 participant
@BrynCooke