Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zipkin reports UNKNOWN_SERVICE : graphql_request for router spans #180

Closed
prasek opened this issue Nov 23, 2021 · 2 comments · Fixed by #210
Closed

Zipkin reports UNKNOWN_SERVICE : graphql_request for router spans #180

prasek opened this issue Nov 23, 2021 · 2 comments · Fixed by #210
Assignees
@Geal

Comments

@prasek
Copy link
Contributor

prasek commented Nov 23, 2021 •
edited
Loading

Describe the bug
As a follow-on to #149 I'm now seeing Zipkin report UNKNOWN_SERVICE : graphql_request for router spans.

The subgraph spans are also offset, so not sure if trace propagation is working correctly.

To Reproduce
Steps to reproduce the behavior:

  1. git clone git@github.com:apollographql/supergraph-demo-fed2.git
  2. make docker-up-router-otel - uses docker-compose.router-otel.yml
  3. make smoke-router
  4. http://localhost:9411/ -> Run Query
  5. see UNKNOWN_SERVICE : graphql_request for router requests
  6. click Show and see the offset subgraph spans

Expected behavior

  1. router to set a default resource/service name so it shows up in the Zipkin serviceName field, and ideally allow setting the field via config.yaml and include it in the config docs
  2. subgraph trace spans to align with the parent router spans, like it does for the Gateway in https://github.com/apollographql/supergraph-demo-fed2#tracing-with-open-telemetry

Output
image

Desktop (please complete the following information):

ProductName:	macOS
ProductVersion:	11.6
BuildVersion:	20G165
@prasek prasek added the triage label Nov 23, 2021
@Geal
Copy link
Contributor

Geal commented Nov 25, 2021

it might be related to open-telemetry/opentelemetry-rust@2d37fd1

@Geal Geal self-assigned this Nov 29, 2021
@Geal Geal added 2021-11 and removed triage labels Nov 29, 2021
This was referenced Nov 29, 2021
Merged
Closed
@Geal
Copy link
Contributor

Geal commented Nov 29, 2021

this should be fixed with #210, at least for item 1. For item 2, the subgraph fetches shifting, I have not been able to reproduce yet

@Geal Geal closed this as completed in #210 Nov 30, 2021
@o0Ignition0o o0Ignition0o mentioned this issue Dec 3, 2021
Merged
o0Ignition0o added a commit that referenced this issue Dec 3, 2021
@o0Ignition0o
v.0.1.0-alpha.2 (#239)
0add5b7 
# [v0.1.0-alpha.2] 2021-12-03

## 🚀🌒 Public alpha release

> An alpha or beta release is in volatile, active development. The release might not be feature-complete, and breaking API changes are possible between individual versions.

## ✨ Features

- JSON log output

## 🐛 Fixes

- Fix Open Telemetry Zipkin report errors [#180](#180)
o0Ignition0o added a commit that referenced this issue Dec 3, 2021
@o0Ignition0o
v.0.1.0-alpha.2 (#239)
cd07c4f 
    # [v0.1.0-alpha.2] 2021-12-03

    ## 🚀🌒 Public alpha release

    > An alpha or beta release is in volatile, active development. The release might not be feature-complete, and breaking API changes are possible between individual versions.

    ## ✨ Features

    - JSON log output

    ## 🐛 Fixes

    - Fix Open Telemetry Zipkin report errors [#180](#180)
@prasek prasek mentioned this issue Dec 6, 2021
Closed
tinnou pushed a commit to Netflix-Skunkworks/router that referenced this issue Oct 16, 2023
@clenfest
release: router-bridge@v0.1.5 (apollographql#180)
a187213
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Geal Geal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

set OTLP service name and namespace apollographql/router
2 participants
@Geal @prasek