-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release automation improvements #2261
Comments
I added a few more things to this list, but I'm not sure how many of them on here are already done (or if this issue was meant to be closed already?) |
They all need to be tackled. Hopefully most won't be a heavy lift and we can do these incrementally each time we release. |
Cool! I added a couple further points above and agree on incrementality. This was a huge improvement that I was very happy to find out about today, so thanks for getting it started! |
This should have been updated as part of the release process for the 1.6.0 release to indicate that Federation v2.2.2 was the active version as of that release. Apologies to the folks who rely on this information being accurate to do their job correctly. In the future, we will introduce automation to eliminate the human factor of this, and that work is being tracked in #2261.
…0. (#2318) This should have been updated as part of the release process for the 1.6.0 release to indicate that Federation v2.2.2 was the active version as of that release. Apologies to the folks who rely on this information being accurate to do their job correctly. In the future, we will introduce automation to eliminate the human factor of this, and that work is being tracked in #2261.
This follows-up #2202 and it consists of several commits which can stand alone, if necessary. Each of those commits has their own message and while I suggest reviewing the totality of the PR, it's worth considering the text of the individual commit messages for additional context on the changes. As a summary of those commits: - Remove destructive `git reset --hard` command which destroyed my local changes - Require a pristine Git checkout of known files prior to releasing - Update Helm Chart version BEFORE `helm-docs` and `helm template` commands. - Do a pre-flight check which asserts availabilty of necessary tools - Remove pre-determined version heading from `NEXT_CHANGELOG.md` - Repair logic which migrates `NEXT_CHANGELOG.md` entries to `CHANGELOG.md` - Support ANY version string rather than just digits-dot-digits-dot-digits. - Remove quotes around invocation of `helm template`'s `--set` flags Contributes to #2261 Co-authored-by: Coenen Benjamin <benjamin.coenen@hotmail.com>
#3116) This removes some automation which existed in the first iteration of the releasing xtask which depended on `octorust`. The steps in the updated `RELEASE_CHECKLIST.md` within #3110 have a list of commands which leverage the `gh` CLI to do effecitely the same thing. The instructions I've used for the last many releases seem to have validated that approach and I suspect we will move in that direction. As an added benefit of depending on `gh`, `octorust` brought in a substantial amount of build-time to the `xtask` crate and a _lot_ of dependencies. (Concretely, I've been always having `--dry-run` and `--current-branch` on with the current instructions, so those options are no longer that useful there anyhow.) Relates to #170 Relates to #2261
…3152) Previously, it was just leaving it off, but it left things a bit unharmonic/off-balance in terms of the resulting changeset template. I'd also just been manually adding those during the release process thus far, so figured I'd just automate it now. Also added a lot of tests and fixed a couple bugs with trailing spaces. Relates to ##2261
Tasks
Release Steps might be
The text was updated successfully, but these errors were encountered: