throw with body in rhai map_response fails

[lennyburdette]

Version 1.18.0

This works (copied from the docs).

fn supergraph_service(service) {
  let f = |request| {
    throw #{
      status: 403,
      body: #{
        errors: [#{
          message: `I have raised a 403`,
          extensions: #{
            code: "ACCESS_DENIED"
          }
        }]
      }
    };
  };

  service.map_request(f);
}

The result (which has the correct 403 status code):

{
  "data": {},
  "errors": [
    {
      "message": "I have raised a 403",
      "extensions": {
        "code": "ACCESS_DENIED"
      }
    }
  ]
}

This does not:

fn supergraph_service(service) {
  let f = |response| {
    throw #{
      status: 403,
      body: #{
        errors: [#{
          message: `I have raised a 403`,
          extensions: #{
            code: "ACCESS_DENIED"
          }
        }]
      }
    };
  };

  service.map_response(f); // RESPONSE NOT REQUEST
}

The result has the correct 403 status code but the response body is

{
  "data": {},
  "errors": [
    {
      "message": ""
    }
  ]
}

Throwing with just a message in map_response works correctly:

fn supergraph_service(service) {
  let f = |response| {
    throw #{
      status: 403,
      message: "wtf"
    };
  };

  service.map_response(f);
}

[garypen]

also: the example in the docs is wrong. I think @lennyburdette must have fixed that when he copied the example.

git diff docs/source/customizations/rhai-api.mdx
diff --git a/docs/source/customizations/rhai-api.mdx b/docs/source/customizations/rhai-api.mdx
index c181f8825..6ca0ea151 100644
--- a/docs/source/customizations/rhai-api.mdx
+++ b/docs/source/customizations/rhai-api.mdx
@@ -108,6 +108,7 @@ fn supergraph_service(service) {
                 }]
             }
         };
+    };
     // Map our request using our closure
     service.map_request(f);
 }