Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

start a configuration reload from a HUP signal #35

Closed
Geal opened this issue Oct 22, 2021 · 1 comment · Fixed by #2015
Closed

start a configuration reload from a HUP signal #35

Geal opened this issue Oct 22, 2021 · 1 comment · Fixed by #2015
Assignees
@Geal
Labels
enhancement An enhancement to an existing feature

Comments

@Geal
Copy link
Contributor

Geal commented Oct 22, 2021

Right now we support configuration reload through filesystem watch. This can be unreliable sometimes (missing udpdates), and it will try to reload files on each save even if we're not done modifying (the router should check the configuration file and schema before replacing, but that's another topic).

Should we support a signal to tell the router to reload its configuration? Specifically, SIGHUP is commonly accepted for that. That would fit well with tools like systemd and its ExecReload command
@o0Ignition0o o0Ignition0o transferred this issue from another repository Nov 4, 2021
@abernix abernix removed the triage label May 23, 2022
@SimonSapin
Copy link
Contributor

SimonSapin commented Aug 12, 2022 •
edited
Loading

Kinda related: we (optionally) do a graceful shutdown on SIGINT (CTRL+C), do we also do that on SIGTERM? Edit: that's #1497

@abernix abernix added the enhancement An enhancement to an existing feature label Oct 24, 2022
@Geal Geal mentioned this issue Oct 27, 2022
Merged
@Geal Geal self-assigned this Oct 27, 2022
@Geal Geal closed this as completed in #2015 Nov 2, 2022
Geal pushed a commit that referenced this issue Nov 2, 2022
@garypen
reload the configuration when receiving the SIGHUP signal (#2015)
c4cce27 
Fix #35 

This adds support for reloading configuration when receiving the SIGHUP
signal. This only works on unix-like platforms, and only with the
configuration file

Co-authored-by: Gary Pennington <gary@apollographql.com>
@abernix abernix mentioned this issue Nov 9, 2022
Merged
tinnou pushed a commit to Netflix-Skunkworks/router that referenced this issue Oct 16, 2023
@abernix
router-bridge: Update to @apollo/query-planner@2.0.0-alpha.6 (apoll…
6f1a703 
…ographql#35)

* router-bridge: Update to `@apollo/query-planner@2.0.0-alpha.6`

Most notably to bring in apollographql/federation#1511

Ref: apollographql/federation@ee84b3fd9df161c3a94

* tests: update snapshots to include `operationKind`

This is expected since the [Ref]erenced PR introduced it!

Ref: apollographql/federation#1427
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Geal Geal

Labels
enhancement An enhancement to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

reload the configuration when receiving the SIGHUP signal apollographql/router
4 participants
@Geal @SimonSapin @abernix @o0Ignition0o