improve our kubernetes example documentation #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and add support for prometheus metrics to our helm chart
✅ Deploy Preview for apollo-router-docs canceled.
|
This comment has been minimized.
This comment has been minimized.
BrynCooke
reviewed
May 10, 2022
fix <> issue in docs.
BrynCooke
approved these changes
May 10, 2022
i.e: v0.1.0-preview.7 -> v0.9.0-rc.0
done: 33e4baf |
or it may lead to confusion if anyone actually tried to use this yaml.
With some details about how to use it.
bnjjj
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and add support for prometheus metrics to our helm chart
I deployed a release of the router into our testing cluster using helm and ensured that I could read the prometheus statistics easily from the deployed router.
fixes: #958