Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add metrics we have using Prometheus #1067

Merged
merged 2 commits into from
May 17, 2022
Merged

doc: add metrics we have using Prometheus #1067

merged 2 commits into from
May 17, 2022

Conversation

bnjjj
Copy link
Contributor

@bnjjj bnjjj commented May 16, 2022

close #1063

Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj requested a review from StephenBarlow as a code owner May 16, 2022 16:53
@bnjjj bnjjj self-assigned this May 16, 2022
@netlify
Copy link

netlify bot commented May 16, 2022

Deploy Preview for apollo-router-docs ready!

Name Link
🔨 Latest commit cf16873
🔍 Latest deploy log https://app.netlify.com/sites/apollo-router-docs/deploys/6282821294cbfe0008e53dcf
😎 Deploy Preview https://deploy-preview-1067--apollo-router-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions

This comment has been minimized.

Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj merged commit 63fa4ab into main May 17, 2022
@bnjjj bnjjj deleted the bnjjj/doc_1063 branch May 17, 2022 09:45
@o0Ignition0o o0Ignition0o mentioned this pull request May 17, 2022
o0Ignition0o added a commit that referenced this pull request May 17, 2022
# [0.9.1] - 2022-05-17

## ❗ BREAKING ❗

### Remove command line options `--apollo-graph-key` and `--apollo-graph-ref` [PR #1069](#1069)
Using these command lime options exposes sensitive data in the process list. Setting via environment variables is now the only way that these can be set.
In addition these setting have also been removed from the telemetry configuration in yaml.

## 🐛 Fixes
### Pin schemars version to 0.8.8 [PR #1075](#1075)
The Schemars 0.8.9 causes compile errors due to it validating default types. Pin the version to 0.8.8.
See issue [#1074](#1074)

### Fix infinite recursion on during parsing [PR #1078](#1078)
During parsing of queries the use of `"` in a parameter value caused infinite recursion. This preliminary fix will be revisited shortly.
## 📚 Documentation

### Document available metrics in Prometheus [PR #1067](#1067)
Add the list of metrics you can have using Prometheus
@BrynCooke BrynCooke added this to the v0.9.1 milestone May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add better documentation about open telemetry metrics
3 participants