Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more information in spans #1119

Merged
merged 7 commits into from
May 25, 2022
Merged

feat: add more information in spans #1119

merged 7 commits into from
May 25, 2022

Conversation

bnjjj
Copy link
Contributor

@bnjjj bnjjj commented May 20, 2022

Related to #911

Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj self-assigned this May 20, 2022
@netlify
Copy link

netlify bot commented May 20, 2022

Deploy Preview for apollo-router-docs canceled.

Name Link
🔨 Latest commit 1cae323
🔍 Latest deploy log https://app.netlify.com/sites/apollo-router-docs/deploys/628cab62c8f4980008df7343

@github-actions

This comment has been minimized.

@bnjjj bnjjj marked this pull request as ready for review May 20, 2022 15:29
apollo-router-core/src/query_planner/mod.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@BrynCooke BrynCooke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gut feeling is that this information should be in a span in the TowerSubgraphService.
Eventually it is very possible that we will have other types of subgraph service that do not actually make an http call.

@bnjjj
Copy link
Contributor Author

bnjjj commented May 23, 2022

@BrynCooke Not sure to understand your comment. At the moment I only put these records on the fetch span which is the function to make the http call to the subgraph. It's not on the subgraph_service span right now it's only used on fetch_node method which make the http request.

@BrynCooke
Copy link
Contributor

Yeah, I think the fetch span should stay as it is, and that a new span should go in TowerSubgraphService.
It's TowerSubgraphService that actually does the 'client' work and knows all about http stuff.

Having this client span fetch means that anything in the subgraph service pipeline such as caching would also be marked as client.

I guess the point I'm trying to make is that the existing fetch span is too early to be a client span.

bnjjj added 6 commits May 24, 2022 11:06
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj requested review from Geal and BrynCooke May 24, 2022 09:55
@bnjjj bnjjj merged commit 05b4f90 into main May 25, 2022
@bnjjj bnjjj deleted the bnjjj/fix_911 branch May 25, 2022 15:14
@abernix abernix added this to the v0.9.3 milestone May 31, 2022
@garypen garypen mentioned this pull request May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants