Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split queries for defer directive #1173

Closed
wants to merge 5 commits into from
Closed

Conversation

bnjjj
Copy link
Contributor

@bnjjj bnjjj commented Jun 1, 2022

Related to #80

  • Split main query into primary and deferred queries
  • Rewrite the InlineFragment implementation
  • Add support of static check for @include and @skip directives

The query is split regarding the @defer directive. If we could statically detect that the selection will be deferred then we just skip it from the primary selection. If not we will clone the selection into deferred_queries and also keep it in the primary query to be able to detect at the execution stage if it's a deferred selection or not.

TODO:

  • To link a deferred node with a deferred query the main idea would be to specify a label on defer if not already provided, then in format response we just skip this label parameter if we detect that's one of our custom label

bnjjj added 5 commits May 31, 2022 18:11
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj requested a review from Geal June 1, 2022 14:15
@bnjjj bnjjj self-assigned this Jun 1, 2022
@bnjjj bnjjj closed this Jun 2, 2022
@abernix abernix deleted the bnjjj/tout_defer branch March 29, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant