Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable integration tests in CI #119

Merged
merged 6 commits into from
Nov 10, 2021
Merged

Conversation

cecton
Copy link
Contributor

@cecton cecton commented Nov 10, 2021

The integration tests have been disabled by #99 and broke (locally) by #111.

@cecton cecton marked this pull request as ready for review November 10, 2021 14:45
@Geal
Copy link
Contributor

Geal commented Nov 10, 2021

good catch! I think we were talking with @o0Ignition0o of moving the gateway to another port anyway (since we're pushing for usage without the config file so default port set to 4000)

Copy link
Contributor

@o0Ignition0o o0Ignition0o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙏

@cecton cecton merged commit d7bad91 into main Nov 10, 2021
@cecton cecton deleted the cecton-renable-integration-tests branch November 10, 2021 15:39
@cecton cecton mentioned this pull request Nov 11, 2021
BrynCooke pushed a commit that referenced this pull request May 24, 2022
Moka has a dependency on Quanta which had an issue with AMD hardware. This is now fixed via [Moka-#119](moka-rs/moka#119).
BrynCooke pushed a commit that referenced this pull request May 24, 2022
Moka has a dependency on Quanta which had an issue with AMD hardware. This is now fixed via [Moka-#119](moka-rs/moka#119).
BrynCooke added a commit that referenced this pull request May 24, 2022
Moka has a dependency on Quanta which had an issue with AMD hardware. This is now fixed via [Moka-#119](moka-rs/moka#119).

Co-authored-by: bryn <bryn@apollographql.com>
BrynCooke pushed a commit that referenced this pull request May 24, 2022
Moka has a dependency on Quanta which had an issue with AMD hardware. This is now fixed via [Moka-#119](moka-rs/moka#119).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants