Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix configuration file in docs #120

Merged
merged 2 commits into from
Nov 10, 2021
Merged

fix configuration file in docs #120

merged 2 commits into from
Nov 10, 2021

Conversation

Geal
Copy link
Contributor

@Geal Geal commented Nov 10, 2021

it was not matching the configuration loader

like #118 but without the jaeger credentials issue

it was not matching the configuration loader

also mark the username and password fields as not skipped so they can be
used from the config file
@Geal Geal requested review from o0Ignition0o and abernix November 10, 2021 15:30
@Geal
Copy link
Contributor Author

Geal commented Nov 10, 2021

I'm merging this so that docs are ok for the release

@Geal Geal merged commit 9916b71 into main Nov 10, 2021
@Geal Geal deleted the fix-config-doc branch November 10, 2021 16:53
@abernix abernix mentioned this pull request Nov 19, 2021
@Geal Geal self-assigned this Dec 1, 2021
tinnou pushed a commit to Netflix-Skunkworks/router that referenced this pull request Oct 16, 2023
…pollographql#120)

This pull request removes the copy pasted functions to generate a Usage Reporting signature, which are now refactored in apollo-utils.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants