Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin clap dependency in Cargo.toml #1232

Merged
merged 3 commits into from
Jun 14, 2022
Merged

Pin clap dependency in Cargo.toml #1232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f9f8a9
Pin clap dependency in Cargo.toml
o0Ignition0o Jun 14, 2022
eff2f6c
changelog
o0Ignition0o Jun 14, 2022
ab3cd3a
wrong version
o0Ignition0o Jun 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions NEXT_CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,15 @@ By [@jcaromiq](https://github.com/jcaromiq) in https://github.com/apollographql/

## 🐛 Fixes ( :bug: )

### Pin clap dependency in Cargo.toml ([PR #1232](https://github.com/apollographql/router/pull/1232))
A minor release of Clap occured yesterday; which introduced a breaking change.

This might lead cargo scaffold users to hit a panic a runtime when the router tries to parse env variables and arguments.

This patch Pins the clap dependency to the version that was available before the release, until the root cause is found and fixed.

By [@o0Ignition0o](https://github.com/o0Ignition0o) in https://github.com/apollographql/router/pull/1232

### Display better error message when on subgraph fetch errors ([PR #1201](https://github.com/apollographql/router/pull/1201))
Show a helpful error message when a subgraph does not return JSON or bad status code

Expand Down
2 changes: 1 addition & 1 deletion apollo-router-scaffold/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ publish = false

[dependencies]
anyhow = "1.0.56"
clap = { version = "3.1.8", features = ["derive"] }
clap = { version = "=3.1.18", features = ["derive"] }
cargo-scaffold = { version = "0.8.3", default-features = false }
regex = "1"
str_inflector = "0.12.0"
Expand Down
4 changes: 2 additions & 2 deletions apollo-router-scaffold/templates/base/xtask/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ apollo-router-scaffold = { git="https://github.com/apollographql/router.git", br
apollo-router-scaffold = { git="https://github.com/apollographql/router.git", tag="v0.9.3"}
{{/if}}
{{/if}}
anyhow = "1.0.56"
clap = "3.1.8"
anyhow = "=1.0.56"
clap = "=3.1.18"
2 changes: 1 addition & 1 deletion apollo-router/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ axum = { version = "0.5.4", features = ["headers", "json", "original-uri"] }
backtrace = "0.3.65"
buildstructor = "0.3.2"
bytes = "1.1.0"
clap = { version = "3.1.18", default-features = false, features = [
clap = { version = "=3.1.18", default-features = false, features = [
"env",
"derive",
"std",
Expand Down
2 changes: 1 addition & 1 deletion apollo-spaceport/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ publish = false

[dependencies]
bytes = "1.1.0"
clap = { version = "3.1.18", default-features = false, features = ["std", "derive"] }
clap = { version = "=3.1.18", default-features = false, features = ["std", "derive"] }
flate2 = "1.0.23"
prost = "0.9.0"
prost-types = "0.9.0"
Expand Down