only send one report for a response with deferred responses #1576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it must measure the latency of the entire operation
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Jeremy Lempereur <jeremy.lempereur@gmail.com>
o0Ignition0o
approved these changes
Aug 23, 2022
the axum response serializer was dropping the following response after the first one if it did not have has_next=true, but that last response was still incorrectly generated
o0Ignition0o
approved these changes
Aug 23, 2022
BrynCooke
reviewed
Aug 23, 2022
| .in_current_span() | ||
| .boxed(), | ||
| if can_be_deferred { | ||
| stream.chain(once(ready(Response::builder().has_next(false).build()))).left_stream() |
BrynCooke
approved these changes
Aug 23, 2022
BrynCooke
reviewed
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it must measure the latency of the entire operation