Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make http_ext::Request and http_ext::Response private #1589

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Make http_ext::Request and http_ext::Response private #1589

merged 1 commit into from
Aug 24, 2022

Conversation

SimonSapin
Copy link
Contributor

Use types from the http crate instead in a number of places.

Part of #1553

@github-actions

This comment has been minimized.

Sign in to view
@SimonSapin SimonSapin mentioned this pull request Aug 23, 2022
Closed
@SimonSapin
Make http_ext::Request and http_ext::Response private
8743d69 
Use types from the http crate instead in a number of places.

Part of #1553
BrynCooke
BrynCooke approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@BrynCooke BrynCooke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

o0Ignition0o
o0Ignition0o reviewed Aug 24, 2022
View reviewed changes
Copy link
Contributor

@o0Ignition0o o0Ignition0o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I m merging this in an hour, unless someone else is raising concerns :)

@o0Ignition0o o0Ignition0o merged commit 6b70abb into main Aug 24, 2022
@o0Ignition0o o0Ignition0o deleted the simon/http-types branch August 24, 2022 14:14
@abernix abernix mentioned this pull request Aug 29, 2022
Merged
@abernix abernix added this to the v1.0.0-alpha.0 milestone Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@o0Ignition0o o0Ignition0o o0Ignition0o left review comments

@bnjjj bnjjj bnjjj approved these changes

@BrynCooke BrynCooke BrynCooke approved these changes

@garypen garypen garypen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SimonSapin @garypen @BrynCooke @bnjjj @o0Ignition0o @abernix