Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change verbosity of state machine logs to trace #1597

Merged
merged 4 commits into from
Aug 26, 2022
Merged

Change verbosity of state machine logs to trace #1597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
89f6ab5
Change verbosity of state machine logs to `trace`
abernix Aug 24, 2022
98fab40
Add CHANGELOG.md for #1578
abernix Aug 24, 2022
9f16a2e
Merge branch 'main' into abernix/change-state-machine-loglevel
abernix Aug 24, 2022
f2012d2
Merge branch 'main' into abernix/change-state-machine-loglevel
Geal Aug 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions NEXT_CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,12 @@ Move the location of the `text` field when exposing the query plan and fill it w

By [@bnjjj](https://github.com/bnjjj) in https://github.com/apollographql/router/pull/1557

### Change state machine log messages to `trace` ([#1578](https://github.com/apollographql/router/issues/1578))

We no longer show internal state machine log events at the `info` level since they are unnecessary during normal operation. They are instead emitted at the `trace` level and can be enabled selectively using the `--log trace` flag.

By [@abernix](https://github.com/abernix) in https://github.com/apollographql/router/pull/1597

### Formatting problem fix of scalar fields selected several times ([PR #1583](https://github.com/apollographql/router/issues/1583))

Fixed a bug where querying scalar fields several times would put `null`s instead of expected values.
Expand Down
2 changes: 1 addition & 1 deletion apollo-router/src/state_machine.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ where
}
};

tracing::info!("transitioned to {}", &new_state);
tracing::trace!("transitioned to {}", &new_state);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@o0Ignition0o seemed okay with debug in his comment on the original issue. I considered it.

My claim would be that it's better to make things more verbose if necessary and bury as much extra distraction as we can unless it's proven consistently necessary to make it louder at less-noisy levels.

state = new_state;

// If we're running then let those waiting proceed.
Expand Down