Add #[non_exhaustive] to relevant types #1614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
o0Ignition0o
approved these changes
Aug 25, 2022
| @@ -333,6 +334,7 @@ impl Server { | |||
| /// Listening address. | |||
| #[derive(Debug, Clone, PartialEq, Deserialize, Serialize, JsonSchema)] | |||
| #[serde(untagged)] | |||
| #[non_exhaustive] | |||
| pub enum ListenAddr { | |||
There was a problem hiding this comment.
cant quite think of anything else, but non exhaustive is the safe bet anyway 😅
There was a problem hiding this comment.
Yeah I’ve reverted this one. I was a bit too mechanical in adding it everywhere :)
… with a few exceptions like `Location` and `PathElement`. Relevant types are: * Public enums * Public structs without any private field See https://doc.rust-lang.org/reference/attributes/type_system.html#the-non_exhaustive-attribute This will allow us adding struct fields or enum variants without it being a breaking change.
SimonSapin
force-pushed
the
simon/exhaustive
branch
from
6493a4b to
9a99c13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… with a few exceptions like
LocationandPathElement.Relevant types are:
See https://doc.rust-lang.org/reference/attributes/type_system.html#the-non_exhaustive-attribute
This will allow us adding struct fields or enum variants without it being a breaking change.
Fixes #1550