Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom listenaddr and endpoints for plugins #1654

Merged
merged 27 commits into from
Sep 7, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
56efa23
super early wip :see_no_evil:
o0Ignition0o Aug 30, 2022
f8469ae
telemetry endpoint works, but i m not happy with the api yet
o0Ignition0o Aug 31, 2022
de2df41
wip
o0Ignition0o Aug 31, 2022
940f182
wip
o0Ignition0o Aug 31, 2022
14a8bd2
wip
o0Ignition0o Sep 1, 2022
d937669
look tests arent passing yet but they are compiling so it s a win in …
o0Ignition0o Sep 1, 2022
81acaaa
getting close, todo: finish separating the main listen_addr from the …
o0Ignition0o Sep 2, 2022
3479ad3
wip
o0Ignition0o Sep 2, 2022
458e4b0
wip
o0Ignition0o Sep 2, 2022
19ed5ea
wip
o0Ignition0o Sep 2, 2022
303b363
wip
o0Ignition0o Sep 2, 2022
b9cc3cc
Merge branch 'main' into igni/custom_endpoints
o0Ignition0o Sep 2, 2022
a1eac49
ok it works, time for tests, then refactor
o0Ignition0o Sep 2, 2022
2acedce
let s try to pass xtask all
o0Ignition0o Sep 2, 2022
a79cfa5
oopsie i see what i forgot ^^'
o0Ignition0o Sep 2, 2022
069c3f1
i think i m doing something wrong with the locks but i m not sure
o0Ignition0o Sep 2, 2022
595e139
found it
o0Ignition0o Sep 2, 2022
bcec753
ok i have refactored the worst part
o0Ignition0o Sep 2, 2022
21c0b2c
wip
o0Ignition0o Sep 2, 2022
26df9c7
ok I m fairly happy with the refactor
o0Ignition0o Sep 2, 2022
1c7a131
refactor telemetry plugin
o0Ignition0o Sep 6, 2022
1aab63b
Merge branch 'main' into igni/custom_endpoints
o0Ignition0o Sep 6, 2022
1a742d0
wip
o0Ignition0o Sep 6, 2022
ffc07a0
add experimental note on the web_endpoints function
o0Ignition0o Sep 6, 2022
0afbc41
review fixes
o0Ignition0o Sep 6, 2022
fa6cfbf
Changelog and docs
o0Ignition0o Sep 7, 2022
2f2b706
Merge branch 'main' into igni/custom_endpoints
o0Ignition0o Sep 7, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions NEXT_CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,29 @@ By [@USERNAME](https://github.com/USERNAME) in https://github.com/apollographql/

# [x.x.x] (unreleased) - 2022-mm-dd
## ❗ BREAKING ❗

The prometheus endpoint now listens to 0.0.0.0:9090/metrics by default. It previously listened to http://0.0.0.0:4000/plugins/apollo.telemetry/prometheus

Have a look at the Features section to learn how to customize the listen address and the path

## 🚀 Features

### Allow users to customize the prometheus endpoint URL ([#1645](https://github.com/apollographql/router/issues/1645))

You can now customize the prometheus endpoint URL in your yml configuration:

```yml
telemetry:
metrics:
prometheus:
listen: 0.0.0.0:9090 # default
path: /metrics # default
enabled: true
```

By [@o0Ignition0o](https://github.com/@o0Ignition0o) in https://github.com/apollographql/router/pull/1654


## 🐛 Fixes
## 🛠 Maintenance
## 📚 Documentation
Loading