Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add map_first_graphql_response, unify execution & supergraph response type #1708

Merged
merged 6 commits into from
Sep 7, 2022

Conversation

SimonSapin
Copy link
Contributor

Fixes #1564, see discussion there.

@SimonSapin SimonSapin added this to the v1.0.0-alpha.3 milestone Sep 6, 2022
Copy link
Contributor

@garypen garypen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some documentation nits.

NEXT_CHANGELOG.md Outdated Show resolved Hide resolved
NEXT_CHANGELOG.md Outdated Show resolved Hide resolved
apollo-router/src/layers/mod.rs Outdated Show resolved Hide resolved
apollo-router/src/layers/mod.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@o0Ignition0o o0Ignition0o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@garypen garypen merged commit 6f8ed64 into main Sep 7, 2022
@garypen garypen deleted the simon/first branch September 7, 2022 10:45
abernix added a commit that referenced this pull request Sep 7, 2022
abernix added a commit that referenced this pull request Sep 7, 2022
@abernix abernix mentioned this pull request Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugins: Change response parts, depending on the body's first payload
4 participants