promote include_subgraph_errors plugin #1776
Conversation
It has been experimental for a while and is now official. fixes: #1773
|
I was too late to comment on this. I'm not massively keen on the name of the plugin, and feel that eventually it could be part of a larger dev plugin in the config. I guess if and when that happens we can just deprecate this one. |
|
@BrynCooke Let's definitely chat about it. I agree this will need to evolve, though many production users have actually taken the effort to make their subgraph errors meaningful and safe and want them exposed, so they'll want a way to do that. |
| @@ -189,7 +189,7 @@ impl Configuration { | |||
| Value::Bool(true), | |||
| ); | |||
| self.plugins.plugins.as_mut().unwrap().insert( | |||
| "experimental.include_subgraph_errors".to_string(), | |||
| "apollo.include_subgraph_errors".to_string(), | |||
There was a problem hiding this comment.
Hmmm I think now it's an apollo one, it's no longer located in self.plugins but in self.apollo_plugins isn't it ?
There was a problem hiding this comment.
I thought it was. User plugins are separate, but I thought experimental and apollo lived together
There was a problem hiding this comment.
I think it is in the wrong place, but the processing of mandatory plugins positions it correctly. We should still fix this at some point.
It has been experimental for a while and is now official.
fixes: #1773