Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate default values for input object fields #2003

Merged
merged 4 commits into from
Nov 2, 2022

Conversation

Geal
Copy link
Contributor

@Geal Geal commented Oct 26, 2022

Fix #1979

When validating variables, we should use default values for object fields if applicable

@github-actions

This comment has been minimized.

@Geal Geal self-assigned this Oct 26, 2022
@Geal Geal added this to the v1-NEXT milestone Oct 26, 2022
@Geal Geal requested review from bnjjj and BrynCooke October 26, 2022 10:10
Copy link
Contributor

@BrynCooke BrynCooke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Geal Geal enabled auto-merge (squash) November 2, 2022 09:51
@Geal Geal merged commit 06aff46 into dev Nov 2, 2022
@Geal Geal deleted the geal/validate-input-object-field-default branch November 2, 2022 13:13
@abernix abernix mentioned this pull request Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

validation doesn't honor default enum values
3 participants