apply tower best practices to services when cloning inner services #2030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I was investigating connection resets I noted that we weren't following tower documentation with respect to cloning inner services: https://docs.rs/tower/latest/tower/trait.Service.html#be-careful-when-cloning-inner-services This PR addresses that. The change to the supergraph seems to be most invasive. I have run the tests manually many times and the change seems good, but probably worth closer examination.
This comment has been minimized.
This comment has been minimized.
bnjjj
approved these changes
Nov 2, 2022
not worth raising a separate PR and this is still in flight...
Geal
suggested changes
Nov 2, 2022
| // a valid course of action. | ||
| self.ready_query_planner_service | ||
| .get_or_insert_with(|| self.query_planner_service.clone()) | ||
| self.query_planner_service |
Geal
approved these changes
Nov 2, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was investigating connection resets I noted that we weren't following tower documentation with respect to cloning inner services.
This PR addresses that. The change to the supergraph seems to be most invasive. I have run the tests manually many times and the change seems good, but probably worth closer examination.