-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra: Publish nightly releases of the Router from dev
source
#2409
Changes from 2 commits
0011ae5
d551da5
be9d34c
35b3a6f
cb2325b
9722eb2
f278e5e
2617501
d6339db
8b98340
9d413b4
04ca9c2
4d40582
aae001e
e92a9a7
b0f9c13
68e4fb8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -59,6 +59,9 @@ parameters: | |
protoc_version: | ||
type: string | ||
default: "21.8" | ||
nightly: | ||
type: boolean | ||
default: false | ||
|
||
# These are common environment variables that we want to set on on all jobs. | ||
# While these could conceivably be set on the CircleCI project settings' | ||
|
@@ -415,6 +418,9 @@ jobs: | |
parameters: | ||
platform: | ||
type: executor | ||
nightly: | ||
type: boolean | ||
default: false | ||
executor: << parameters.platform >> | ||
environment: | ||
<<: *common_job_environment | ||
|
@@ -424,15 +430,18 @@ jobs: | |
MACOS_PRIMARY_BUNDLE_ID: com.apollographql.router | ||
steps: | ||
- checkout | ||
- run: | ||
name: Initialize submodules | ||
command: git submodule update --recursive --init | ||
- when: | ||
condition: | ||
equal: [*macos_build_executor, << parameters.platform >>] | ||
steps: | ||
- install_minimal_rust | ||
- macos_install_baseline | ||
# This will set the version to inlude current date and commit hash | ||
- when: | ||
condition: | ||
equal: [true, << parameters.nightly >>] | ||
steps: | ||
- run: cargo xtask release prepare nightly | ||
- run: | ||
command: > | ||
cargo xtask dist | ||
|
@@ -461,6 +470,12 @@ jobs: | |
sudo apt-get update | ||
- install_minimal_rust | ||
- linux_amd_install_baseline | ||
# This will set the version to inlude current date and commit hash | ||
- when: | ||
condition: | ||
equal: [true, << parameters.nightly >>] | ||
steps: | ||
- run: cargo xtask release prepare nightly | ||
- run: | ||
command: > | ||
cargo xtask dist | ||
|
@@ -481,6 +496,12 @@ jobs: | |
sudo apt-get update | ||
- install_minimal_rust | ||
- linux_arm_install_baseline | ||
# This will set the version to inlude current date and commit hash | ||
- when: | ||
condition: | ||
equal: [true, << parameters.nightly >>] | ||
steps: | ||
- run: cargo xtask release prepare nightly | ||
- run: | ||
command: > | ||
cargo xtask dist | ||
|
@@ -515,6 +536,12 @@ jobs: | |
git-fetch-with-cli = true | ||
"@ | ||
- windows_install_baseline | ||
# This will set the version to inlude current date and commit hash | ||
- when: | ||
condition: | ||
equal: [true, << parameters.nightly >>] | ||
steps: | ||
- run: cargo xtask release prepare nightly | ||
- run: | ||
command: > | ||
cargo xtask dist | ||
|
@@ -604,6 +631,8 @@ jobs: | |
|
||
workflows: | ||
ci_checks: | ||
when: | ||
not: << pipeline.parameters.nightly >> | ||
Comment on lines
+665
to
+666
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Mildly frustratingly, this is a requirement of the way that CircleCI invokes workflows, so this will have to be present on each new workflow we may potentially add here in the future. |
||
jobs: | ||
- lint: | ||
matrix: | ||
|
@@ -670,7 +699,18 @@ workflows: | |
requires: | ||
- prepare_patch_release_approval | ||
|
||
nightly: | ||
when: << pipeline.parameters.nightly >> | ||
jobs: | ||
- build_release: | ||
matrix: | ||
parameters: | ||
platform: | ||
abernix marked this conversation as resolved.
Show resolved
Hide resolved
|
||
[macos_build, windows_build, amd_linux_build, arm_linux_build] | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note that this doesn't currently actually publish anything to GitHub Releases like normal releases. Assuming these jobs don't start failing immediately, my next steps are to introduce a step that saves these to CircleCI artifacts:
Roughly documented here. |
||
release: | ||
when: | ||
not: << pipeline.parameters.nightly >> | ||
jobs: | ||
- build_release: | ||
matrix: | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually not related to this PR, but should no longer be necessary after #1856