Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Use nu-ansi-term to replace unmaintained ansi_term #2844

Merged
merged 2 commits into from
Apr 20, 2023
Merged

deps: Use nu-ansi-term to replace unmaintained ansi_term #2844

merged 2 commits into from
Apr 20, 2023

Conversation

yanns
Copy link
Contributor

@yanns yanns commented Mar 23, 2023

Partially fixes https://rustsec.org/advisories/RUSTSEC-2021-0139

clap is still depending on ansi_term.

cargo audit before the change:

Crate:     ansi_term
Version:   0.12.1
Warning:   unmaintained
Title:     ansi_term is Unmaintained
Date:      2021-08-18
ID:        RUSTSEC-2021-0139
URL:       https://rustsec.org/advisories/RUSTSEC-2021-0139
Dependency tree:
ansi_term 0.12.1
├── clap 2.34.0
│   ├── structopt 0.3.26
│   │   └── cargo-scaffold 0.8.7
│   │       └── apollo-router-scaffold 1.12.1
│   └── cargo-scaffold 0.8.7
└── apollo-router 1.12.1
    ├── throw-error 0.1.0
    ├── supergraph_sdl 0.1.0
    ├── rhai-surrogate-cache-key 0.1.0
    ├── rhai-subgraph-request-log 0.1.0
    ├── rhai-logging 0.1.0
    ├── rhai-error-response-mutate 0.1.0
    ├── rhai-data-response-mutate 0.1.0
    ├── propagate-status-code 0.1.0
    ├── op-name-to-header 0.1.0
    ├── jwt-claims 0.1.0
    ├── hello-world 0.1.0
    ├── forbid_anonymous_operations_rhai 0.1.0
    ├── forbid-anonymous-operations 0.1.0
    ├── external-subgraph 0.1.0
    ├── cookies-to-headers 0.1.0
    ├── context-data 0.1.0
    ├── async-allow-client-id 0.1.0
    ├── apollo-router-benchmarks 1.12.1
    └── add-timestamp-header 0.1.0

cargo audit after the change:

Crate:     ansi_term
Version:   0.12.1
Warning:   unmaintained
Title:     ansi_term is Unmaintained
Date:      2021-08-18
ID:        RUSTSEC-2021-0139
URL:       https://rustsec.org/advisories/RUSTSEC-2021-0139
Dependency tree:
ansi_term 0.12.1
└── clap 2.34.0
    ├── structopt 0.3.26
    │   └── cargo-scaffold 0.8.7
    │       └── apollo-router-scaffold 1.12.1
    └── cargo-scaffold 0.8.7

Copy link
Contributor

@bnjjj bnjjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay @yanns, could you rebase on dev and merge conflict in order to merge it please ?

@yanns
Copy link
Contributor Author

yanns commented Apr 8, 2023

Sorry for the delay @yanns, could you rebase on dev and merge conflict in order to merge it please ?

done

@yanns
Copy link
Contributor Author

yanns commented Apr 8, 2023

I'll fix the tests

@yanns
Copy link
Contributor Author

yanns commented Apr 8, 2023

the project is compiling again. Ready to review.

@bnjjj bnjjj enabled auto-merge (squash) April 20, 2023 12:45
@bnjjj bnjjj merged commit af58509 into apollographql:dev Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants