Fix: Traffic shaping configuration fallback for experimental_enable_http2 #2976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o the all configuration
This comment has been minimized.
This comment has been minimized.
o0Ignition0o
changed the title
o0Ignition0o
requested review from
Geal,
bnjjj and
BrynCooke
and removed request for
Geal
bnjjj
approved these changes
Apr 19, 2023
Geal
approved these changes
Apr 19, 2023
abernix
reviewed
Apr 21, 2023
Comment on lines
1
to
5
| ### fix: Traffic shaping configuration fallback for experimental_enable_http2 | ||
|
|
||
| Fix a bug where experimental_enable_http2 wouldn't properly apply when a global configuration was set. | ||
|
|
||
| By [@o0Ignition0o](https://github.com/o0Ignition0o) in https://github.com/apollographql/router/pull/2976 |
There was a problem hiding this comment.
Just found this in my unsent messages. Alas.
Suggested change
| ### fix: Traffic shaping configuration fallback for experimental_enable_http2 | |
| Fix a bug where experimental_enable_http2 wouldn't properly apply when a global configuration was set. | |
| By [@o0Ignition0o](https://github.com/o0Ignition0o) in https://github.com/apollographql/router/pull/2976 | |
| ### Global subgraph configuration for `experimental_enable_http2` works | |
| Fix a bug where experimental_enable_http2 wouldn't properly apply when a global configuration was set. | |
| By [@o0Ignition0o](https://github.com/o0Ignition0o) in https://github.com/apollographql/router/pull/2976 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug where
experimental_enable_http2wouldn't properly apply when a global configuration was set.