Ensure --prerelease flag is passed to gh create release for pre-releases
#3004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@abernix, please consider creating a changeset entry in |
…eleases This changes our script to be explicit and pass the `--prerelease` version to our increasingly automated release pipeline when the `-` character is detected in the "version" property of the release being published. Typically, GitHub marks "latest" versions "based on semver"[1], but GitHub still marks "pre-release versions" (as defined by Semver 2.0 [2]) as "latest" irregardless of that meaning to semver. This seems a bit unexpected, but it is the way it is, so we'll account for it by making sure we're explicit. [1]: https://docs.github.com/en/repositories/releasing-projects-on-github/managing-releases-in-a-repository#:~:text=the%20latest%20release%20label%20will%20automatically%20be%20assigned%20based%20on%20semantic%20versioning [2]: https://semver.org/#spec-item-9 Follows-up: #3003 (root-cause) (root-cause) (root-cause) (root-cause)
abernix
force-pushed
the
abernix/gh-release-publish-prerelease
branch
from
325ed8a
to
c6d5f63
Compare
o0Ignition0o
suggested changes
Apr 26, 2023
Co-authored-by: Jeremy Lempereur <jeremy.lempereur@iomentum.com>
o0Ignition0o
approved these changes
Apr 26, 2023
bnjjj
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes our script to be explicit and pass the
--prereleaseversionto our increasingly automated release pipeline when the
-character isdetected in the "version" property of the release being published.
Typically, GitHub marks "latest" versions "based on semver"1, but GitHub
still marks "pre-release versions" (as defined by Semver 2.0 2) as
"latest" irregardless of that meaning to semver.
This seems a bit unexpected, but it is the way it is, so we'll account for
it by making sure we're explicit.
Follows-up: #3003 (root-cause) (root-cause) (root-cause) (root-cause)