-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check the authorization status of implementors of an interface #3588
Merged
Geal
merged 16 commits into
geal/authorization-directives
from
geal/authorization-interface
Aug 22, 2023
Merged
check the authorization status of implementors of an interface #3588
Geal
merged 16 commits into
geal/authorization-directives
from
geal/authorization-interface
Aug 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `@authenticated` is not set consistently on all types implementing an interface, then a query on that interface should use fragments
CI performance tests
|
Would this also be an issue for unions? type B @authenticated {
id: ID
}
type A {
id: ID
}
union I = A | B
type Query {
test: String
uni: I!
} |
if the implementors of an interface have different authorization requirements on the interface fields, then the field should not be authorized, unless it is inside a fragment with a type condition
I have a good approach for interfaces now, checking for unions next |
there's a test for unions in 924a894, it works :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If authorization directives are not set consistently on all types implementing an interface, then a query on that interface should use fragments.
In the same way, if they are not applied consistently on the fields of the interface, the query should use fragments.
As an example, with this schema:
The query:
should be filtered as:
While this one:
will be filtered as:
Todo:
@authenticated
:@requiresScopes
@policy
Checklist
Complete the checklist (and note appropriate exceptions) before a final PR is raised.
Exceptions
Note any exceptions here
Notes
[^1]. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.
[^2]. Configuration is an important part of many changes. Where applicable please try to document configuration examples.
[^3]. Tick whichever testing boxes are applicable. If you are adding Manual Tests:
- please document the manual testing (extensively) in the Exceptions.
- please raise a separate issue to automate the test and label it (or ask for it to be labeled) as
manual test