-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update apollo-compiler #5753
Conversation
CI performance tests
|
@@ -244,7 +244,7 @@ fn test_if_directives_with_arguments_applied_on_queries_are_ok() { | |||
} | |||
|
|||
#[test] | |||
#[should_panic(expected = r#"unused variable: `$some_var`"#)] | |||
#[should_panic(expected = r#"snapshot assertion"#)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The expected error changed because apollo-compiler fixed validation. This test still fails for other reasons, which will be addressed in #5743.
@@ -0,0 +1,11 @@ | |||
### Fix GraphQL query directives validation bug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if it's worth adding a changeset for this, because as far as we know, none of our users have any query that does this... I also struggled to come up with a code example using this syntax that you could actually use for anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd keep the changeset. It's still a fix, even if it doesn't actually affect anyone.
query ($var: Int) @directive(arg: $var)
is now accepted - it used to raise an unused variable error for$var
.I also moved some remaining apollo-rs dependency version declarations to use the
.workspace = true
syntax, to remove multiple versions of the same crate from the dependency tree.Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩