Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use progressive override when using federation 2.7 and above. #5754

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

o0Ignition0o
Copy link
Contributor

A bug in the way we extracted progressive override metadata from the schema would lead to the plugin not being enabled when using join 0.5.

A bug in the way we extracted progressive override metadata from the schema would lead to the plugin not being enabled when using join 0.5.
@router-perf
Copy link

router-perf bot commented Jul 31, 2024

CI performance tests

  • const - Basic stress test that runs with a constant number of users
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • enhanced-signature - Enhanced signature enabled
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • extended-reference-mode - Extended reference mode enabled
  • large-request - Stress test with a 1 MB request payload
  • no-tracing - Basic stress test, no tracing
  • reload - Reload test over a long period of time at a constant rate of users
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • step-local-metrics - Field stats that are generated from the router rather than FTV1
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload

@o0Ignition0o o0Ignition0o requested a review from clenfest July 31, 2024 11:25
@o0Ignition0o o0Ignition0o marked this pull request as ready for review July 31, 2024 11:26
@o0Ignition0o o0Ignition0o requested review from a team as code owners July 31, 2024 11:26
Copy link
Member

@trevor-scheer trevor-scheer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! I am really not sure why I capped it at 0.4, I can't think of a good reason.

@o0Ignition0o o0Ignition0o merged commit 2ea66c2 into dev Jul 31, 2024
14 checks passed
@o0Ignition0o o0Ignition0o deleted the igni/join_05_progressive_override branch July 31, 2024 16:24
@abernix abernix mentioned this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants