Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix session counting and the reporting of file handle shortage #5834

Merged
merged 4 commits into from
Aug 16, 2024

Conversation

garypen
Copy link
Contributor

@garypen garypen commented Aug 16, 2024

Session counting incorrectly included connections to the health check or other non-graphql connections. This is now corrected so that only connections to the main graphql port are counted.

Warnings about file handle shortages are now handled correctly as a global resource.

Note: This was manually tested since integration/unit testing isn't really viable.

Session counting incorrectly included connections to the health check or
other non-graphql connections. This is now corrected so that only
connections to the main graphql port are counted.

Warnings about file handle shortages are now handled correctly as a
global resource.
@garypen garypen self-assigned this Aug 16, 2024
@garypen garypen requested review from a team as code owners August 16, 2024 08:50

This comment has been minimized.

@router-perf
Copy link

router-perf bot commented Aug 16, 2024

CI performance tests

  • const - Basic stress test that runs with a constant number of users
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • enhanced-signature - Enhanced signature enabled
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • extended-reference-mode - Extended reference mode enabled
  • large-request - Stress test with a 1 MB request payload
  • no-tracing - Basic stress test, no tracing
  • reload - Reload test over a long period of time at a constant rate of users
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • step-local-metrics - Field stats that are generated from the router rather than FTV1
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload

@garypen garypen requested a review from a team as a code owner August 16, 2024 08:59
The listener had its own custom rate limiting for log messages. The
router comes with a standard mechanism for rate limiting log messages.
Remove the custom rate limiting mechanism and advised in the changelog
that standard rate limiting configuration should be used.
Copy link
Contributor

@BrynCooke BrynCooke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but put in the description of the PR that this was manually tested and cannot be unit tested.

@garypen garypen removed the request for review from IvanGoncharov August 16, 2024 12:08
@garypen garypen merged commit b340bde into dev Aug 16, 2024
14 checks passed
@garypen garypen deleted the garypen/fix-sessions-and-handle-reporting branch August 16, 2024 13:07
@abernix abernix mentioned this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants