-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ease of use debugging #5850
feat: ease of use debugging #5850
Conversation
5aa4358
to
9f7d9d2
Compare
@garypen let me know if there's any more change you would like. |
@garypen @BrynCooke please let me know anything else that I need to do to get this merged. |
let me know if you'd like me to rebase this branch with latest dev branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, it's much appreciated.
If we make this change, it may be a little surprising to users, since their output heaptrack data files will now have a hostname in them. I don't think that's a big deal, since we aren't offering any guarantees about the stability of output debug file names. However, I would like this to be called out explicitly in the changelog.
Once you decide exactly which format of output file name to use, please update the changelog so that it has an example that illustrates the impact of the change.
3b58e8e
to
cfbd991
Compare
@garypen does this look better? Sorry about the text in changeset, English is my second language. But if you suggest something, I'll use it. |
Looks great! Thanks for pushing this forward. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for the contribution!
@garypen not sure why CI is failing, anything I can do to help? |
It's an issue relating to a test which won't work for external contributions. I'm going to merge your PR without waiting for the tests to pass. It's a change that won't impact any of our tests anyway... |
When we want to use debug mode, we can only get 1 file per node in Kubernetes, this change allows us to do 2 things:
restartPolicy
of pod as desired.Fixes #5789
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩