Add ability to alias standard attributes for telemetry

[bnjjj]

There is an issue when using standard attributes (on cache for example) because on new relic entity.type is a reserved attribute name and so it won’t work properly. cf Learn about New Relic entities Moreover entity.type is not consistent with our other graphql attributes (prefixed by graphql.). So we rename entity.type attribute to graphql.entity.type.

In order to make it work and that could also answer other use cases that would be great if we can alias the name of a standard attribute like this:

telemetry:
  instrumentation:
    spans:
      mode: spec_compliant # Docs state this significantly improves performance: https://www.apollographql.com/docs/router/configuration/telemetry/instrumentation/spans#spec_compliant
    instruments:
      cache: # Cache instruments configuration
        apollo.router.operations.entity.cache: # A counter which counts the number of cache hit and miss for subgraph requests
          attributes:
            graphql.entity.type:
              alias: entity_type # ENABLED and aliased to entity_type

Fixes #5930

---

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

• Changes are compatible¹
• Documentation² completed
• Performance impact assessed and acceptable
• Tests added and passing³
  • Unit Tests
  • Integration Tests
  • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩

2. Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩

3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩

[router-perf]

CI performance tests

• connectors-const - Connectors stress test that runs with a constant number of users
• const - Basic stress test that runs with a constant number of users
• demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
• demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
• enhanced-signature - Enhanced signature enabled
• events - Stress test for events with a lot of users and deduplication ENABLED
• events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
• events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
• events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
• events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
• events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
• extended-reference-mode - Extended reference mode enabled
• large-request - Stress test with a 1 MB request payload
• no-tracing - Basic stress test, no tracing
• reload - Reload test over a long period of time at a constant rate of users
• step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
• step-local-metrics - Field stats that are generated from the router rather than FTV1
• step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
• step - Basic stress test that steps up the number of users over time
• xlarge-request - Stress test with 10 MB request payload
• xxlarge-request - Stress test with 100 MB request payload

Needs docs

[BrynCooke]

We already have:

telemetry:
  instrumentation:
    instruments:
      graphql:
        foo:
          attributes:
            graphql.type.name: false
            graphql.operation.name: false
            graphql.field.name: false
            graphql.list.length: false
            graphql.field.type: false

Let's align on these names rather than adding alias support.

[bnjjj]

@BrynCooke Why not doing both ? I think we could still benefit from having aliases because sometimes some users would want to make a search over attributes or so and if they have a list of attributes and already use these attribute names somewhere else that could be an issue. So giving the ability to alias these standard attributes would still be valuable

[BrynCooke]

Agree! Let's rename first and then we can take out the bit in the doc talking about new relic.