Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix v8 gauges on hot reload #5999

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Fix v8 gauges on hot reload #5999

merged 1 commit into from
Sep 13, 2024

Conversation

BrynCooke
Copy link
Contributor

@BrynCooke BrynCooke commented Sep 12, 2024

The v8 heap usage and queue gauges were not working after hot reload.
This is because gauges MUST be created after the global meter provider is updated.
This builds on the work from #5996 by introducing an activate function to populate the gauges when we are ready.
The integration test from 5996 is extended to test for the extra metrics.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Bug fix, no docs needed
Unit tests don't capture reload of router, so this is done in integration tests.

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@router-perf
Copy link

router-perf bot commented Sep 12, 2024

CI performance tests

  • connectors-const - Connectors stress test that runs with a constant number of users
  • const - Basic stress test that runs with a constant number of users
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • enhanced-signature - Enhanced signature enabled
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • extended-reference-mode - Extended reference mode enabled
  • large-request - Stress test with a 1 MB request payload
  • no-tracing - Basic stress test, no tracing
  • reload - Reload test over a long period of time at a constant rate of users
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • step-local-metrics - Field stats that are generated from the router rather than FTV1
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload

This comment has been minimized.

These need to be refreshed every time tlemetry is reloaded.
@BrynCooke BrynCooke marked this pull request as ready for review September 12, 2024 15:51
@BrynCooke BrynCooke requested review from a team as code owners September 12, 2024 15:51
@BrynCooke BrynCooke merged commit 5f48a8f into dev Sep 13, 2024
14 checks passed
@BrynCooke BrynCooke deleted the bryn/fix-gauges2 branch September 13, 2024 09:25
TylerBloom pushed a commit that referenced this pull request Sep 16, 2024
Co-authored-by: bryn <bryn@apollographql.com>
@abernix abernix mentioned this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants