Remove legacy schema introspection #6139
Conversation
✅ Docs Preview ReadyNo new or changed pages found. |
This comment has been minimized.
This comment has been minimized.
|
If introspection is now completely in rust, does that mean v8 won't start up with just |
|
CI performance tests
|
| let js_planner = match self { | ||
| Self::Js(js) => js.clone(), | ||
| Self::Both { js, .. } => js.clone(), | ||
| Self::Rust(_) => { | ||
| // JS "planner" (actually runtime) was not created for planning | ||
| // but is still needed for introspection, so create it now | ||
| Self::js_planner(sdl, configuration, old_js_planner).await? | ||
| } | ||
| }; |
There was a problem hiding this comment.
If introspection is now completely in rust, does that mean v8 won't start up with just
experimental_query_planner_mode: new?
Correct. This is the relevant code change. Here the badly-named js_planner represents a V8 runtime.
I didn’t realize we publish docs from next, I’ll make a separate PR
|
Docs PR into |
| @@ -959,26 +978,6 @@ async fn query_planner_redis_update_planner_mode() { | |||
| .await; | |||
| } | |||
|
|
|||
| #[tokio::test(flavor = "multi_thread")] | |||
| async fn query_planner_redis_update_introspection() { | |||
There was a problem hiding this comment.
This test is removed because it specifically tests that enabling introspection in config changes Redis cache keys. This PR changes caching_query_planner.rs for this to no longer be the case, since introspection responses (or "introspection is disabled" errors) are now never in this cache.
SimonSapin
changed the title
| <MinVersion version="1.51.0"> | ||
|
|
||
| ### Introspection response caching | ||
|
|
||
| </MinVersion> |
There was a problem hiding this comment.
Not as far as I can see
apollo-router/src/introspection.rs
Outdated
| debug: None, | ||
| type_conditioned_fetching: false, | ||
| }, | ||
| fn execute_intropsection(schema: &spec::Schema, doc: &ParsedDocument) -> graphql::Response { |
There was a problem hiding this comment.
| fn execute_intropsection(schema: &spec::Schema, doc: &ParsedDocument) -> graphql::Response { | |
| fn execute_introspection(schema: &spec::Schema, doc: &ParsedDocument) -> graphql::Response { |
There was a problem hiding this comment.
I seem to like that particular typo, I made it in two places
Schema introspection now runs natively without involving JavaScript code. We have high confidence that the two implementations return matching responses based on differential testing fuzzing arbitrary queries against a large schema, and testing a corpus of customer schemas against a comprehensive query.
In Router YAML configuration:
experimental_introspection_modekey is removed,newis now the only behaviorsupergraph.query_planning.legacy_introspection_cachingkey is removed, the behavior is now similar to what wasfalse: introspection responses are not part of the query plan cache but instead in a separate, small, in-memory only cache.Migrations ensure that existing configuration files will keep working.
Fixes ROUTER-338
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩