Geal/clean up dedup on cancel2 #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-router-docs canceled.
|
garypen
approved these changes
Apr 1, 2022
| @@ -53,7 +53,7 @@ server: | |||
| ``` | |||
| In addition, other existing uplink env variables are now also configurable via arg. | |||
|
|
|||
| - **Make deduplication and caching more robust against cancellation** [PR #752](https://github.com/apollographql/router/pull/752) | |||
| - **Make deduplication and caching more robust against cancellation** [PR #752](https://github.com/apollographql/router/pull/752) [PR #758](https://github.com/apollographql/router/pull/758) | |||
There was a problem hiding this comment.
Probably need a new title here. The nature of this change is to "eliminate memory leaks when tasks are cancelled" (or something like that).
bnjjj
approved these changes
Apr 4, 2022
o0Ignition0o
approved these changes
Apr 5, 2022
| @@ -53,7 +53,7 @@ server: | |||
| ``` | |||
| In addition, other existing uplink env variables are now also configurable via arg. | |||
|
|
|||
| - **Make deduplication and caching more robust against cancellation** [PR #752](https://github.com/apollographql/router/pull/752) | |||
| - **Make deduplication and caching more robust against cancellation** [PR #752](https://github.com/apollographql/router/pull/752) [PR #758](https://github.com/apollographql/router/pull/758) | |||
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #758