Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: propagate error extensions originating from subgraphs following the include_subgraph_error plugin conf #839

Merged
merged 4 commits into from
Apr 13, 2022

Conversation

bnjjj
Copy link
Contributor

@bnjjj bnjjj commented Apr 12, 2022

close #838

…the include_subgraph_error plugin conf

Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj self-assigned this Apr 12, 2022
@bnjjj bnjjj requested review from garypen and Geal April 12, 2022 15:10
@netlify
Copy link

netlify bot commented Apr 12, 2022

Deploy Preview for apollo-router-docs canceled.

Name Link
🔨 Latest commit 59f8ef3
🔍 Latest deploy log https://app.netlify.com/sites/apollo-router-docs/deploys/62569ebd44b32900091419dc

@github-actions

This comment has been minimized.

bnjjj added 2 commits April 12, 2022 17:11
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Copy link
Contributor

@garypen garypen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

NEXT_CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj enabled auto-merge (squash) April 13, 2022 09:58
@bnjjj bnjjj merged commit a5461c3 into main Apr 13, 2022
@bnjjj bnjjj deleted the bnjjj/fix_838 branch April 13, 2022 10:09
@BrynCooke BrynCooke added this to the v0.1.0-preview.5 milestone Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error extensions originating from subgraphs are not propagated
4 participants